Use more generics, less trailing whitespace in the dataverse package (#775) #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@landreev can you review this pull request, in particular the are around: |
bencomp
added a commit
to bencomp/dataverse
that referenced
this pull request
Aug 23, 2015
This adds test expecting that `null` DataFiles, DataFiles without content type and DataFiles with a bogus content type (`"foo/bar"`) are *not* classed as files of types that Dataverse handles in specific ways. Also, for these files the tests expect that no thumbnail can be generated. In my PR IQSS#2422 I changed the behaviour of `DataFileServiceBean.getFileClass` to return `null` when the input is `null`. This is still discussed, so I don't test for this behaviour. The same goes for `DataFileServiceBean.ingestableAsTabular`; this method is not tested at all at the moment. To make the tests pass, I changed the `isSpssPorFile` and `isSpssSavFile` methods to return `false` when the input is `null`. Hopefully this makes sense to you too :) @scolapasta, @landreev and @michbarsinai, I'll happily discuss these suggestions.
bencomp
added a commit
to bencomp/dataverse
that referenced
this pull request
Jan 14, 2016
This adds test expecting that `null` DataFiles, DataFiles without content type and DataFiles with a bogus content type (`"foo/bar"`) are *not* classed as files of types that Dataverse handles in specific ways. Also, for these files the tests expect that no thumbnail can be generated. In my PR IQSS#2422 I changed the behaviour of `DataFileServiceBean.getFileClass` to return `null` when the input is `null`. This is still discussed, so I don't test for this behaviour. The same goes for `DataFileServiceBean.ingestableAsTabular`; this method is not tested at all at the moment. To make the tests pass, I changed the `isSpssPorFile` and `isSpssSavFile` methods to return `false` when the input is `null`. Hopefully this makes sense to you too :) @scolapasta, @landreev and @michbarsinai, I'll happily discuss these suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lists orMaps.ingestableAsTabular(DataFile dataFile)returnfalsewhen the input isnull(instead of "unknown"/"other").getFileAccessRequesters.It really looks more scary than it is.